Added additional macros/constants to sys/lcd.h and created sys/spi.h #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriweb
reviewed
Jan 14, 2025
src/ce/include/sys/spi.h
Outdated
| } while(0) | ||
|
|
||
| /** @todo Implement vsync */ | ||
| #define SPI_UNINVERT_COLORS() SPI_COMMAND(0x20) |
Member
There was a problem hiding this comment.
Maybe SPI_LCD_* instead of SPI_* for those?
Contributor
Author
There was a problem hiding this comment.
Now that calc84maniac has worked on lcddrvce, it might be more appropriate to remove some of the SPI code
Member
|
Do we still need this |
Contributor
Author
This might be later addressed in this issue #672. I think some of the macros I wanted to add here to C are already included in |
Member
|
I think we already have lcddrvce too |
Contributor
Author
It still doesn't cover all macros. Such as the macro constants I suggested here for lcd_control |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add some additional macros/constants to
sys/lcd.h; such as being able to set RGB/BGR and Bits per pixel withlcd_VideoMode = LCD_BGR565using the lower 16bits oflcd_Control, or just the Bits per pixel usinglcd_VideoBPP = LCD_INDEXED8to set the lower 8bits oflcd_Control.Additionally, I thought it would be nice to add
#define lcd_Ram8 ((uint8_t*)0xD40000)and#define lcd_Ram16 ((uint16_t*)0xD40000)tosys/lcd.h.I also added
sys/spi.h, which contains #define's for the SPI registers, along with some macro routines to send SPI commands and parameters (based of the SPI sending example from WikiTI). There are also some macros for Inverting the colors, and for setting Row-Major/Column-Major through the SPI commands.